[ListItem] Move the selected prop from MenuItem to ListItem #12602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oliviertassinari I tried to modify tests to reflect those changes. Looking at ArgosCI results, they look normal to me (I added a selected state at the end of each list, which creates a difference). Should I "declare" something somewhere to let ArgosCI know those differences are OK? |
the-question
force-pushed
the
move-selected-from-menuitem-to-listitem
branch
from
73a5225
to
c08e80c
Compare
the-question
force-pushed
the
move-selected-from-menuitem-to-listitem
branch
from
c08e80c
to
4b068ff
Compare
oliviertassinari
changed the title
…cted property is from ListItem. Updated test
oliviertassinari
force-pushed
the
move-selected-from-menuitem-to-listitem
branch
from
4b068ff
to
a80bfef
Compare
oliviertassinari
added
new feature
oliviertassinari
force-pushed
the
move-selected-from-menuitem-to-listitem
branch
from
a80bfef
to
effed02
Compare
|
@the-question Don't worry about Argos-CI, there is nothing you need to do about it. The admins on the project can manually approve the changes after reviewing them. |
|
@the-question Thank you! |
|
@oliviertassinari Thanks for the "hint" about Argos-CI! |
2 tasks
marcelpanse
pushed a commit
to marcelpanse/material-ui
that referenced
this pull request
Oct 2, 2018
* Added selected property to ListItem * Added selected example in ListItem documentation * Modified tests to include testing of ListItem'selected property * Removed selected property from MenuItem. Modified doc to specify selected property is from ListItem. Updated test * Corrected example. Fixed missing style * Modified components spec * Updated docs API * Prettified demo * should be ready to be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8667.