Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ClickAwayListener] Prevent rerendering #12613

Merged
merged 1 commit into from Aug 21, 2018
Merged

[ClickAwayListener] Prevent rerendering #12613

merged 1 commit into from Aug 21, 2018

Conversation

shcherbyakdev
Copy link
Contributor

@shcherbyakdev shcherbyakdev commented Aug 21, 2018 •
edited by oliviertassinari

Closes #12288

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: ClickAwayListener The React component labels Aug 21, 2018
@oliviertassinari oliviertassinari changed the title fix bug with event loss in ClickAwayListener [ClickAwayListener] Prevent rerendering Aug 21, 2018
@oliviertassinari oliviertassinari merged commit 199db2a into mui:master Aug 21, 2018
@oliviertassinari
Copy link
Member

@shcherbyakdev It's a great first pull request on Material-UI 👌🏻. Thank you for giving it a shot!

marcelpanse pushed a commit to marcelpanse/material-ui that referenced this pull request Oct 2, 2018
@shcherbyakdev @marcelpanse
[ClickAwayListener] Prevent rerendering (mui#12613)
738d1b1
@oliviertassinari oliviertassinari mentioned this pull request Apr 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: ClickAwayListener The React component performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shcherbyakdev @oliviertassinari