[ci] Consider only files changed on the built branch #12627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git diff COMMIT includes all files changed between COMMIT and the most recent common commit of COMMIT and HEAD. We only want files changed on this branch though.
|
@eps1lon We are getting to the bottom of it :). |
|
By the way, I have left you a message on gitter. |
marcelpanse
pushed a commit
to marcelpanse/material-ui
that referenced
this pull request
Oct 2, 2018
git diff COMMIT includes all files changed between COMMIT and the most recent common commit of COMMIT and HEAD. We only want files changed on this branch though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff COMMIT includes all files changed between COMMIT and the most recent common commit of COMMIT and HEAD. We only want files changed on this branch though.
You can see the old behavior at https://circleci.com/gh/mui-org/material-ui/41213
It also includes files that were changed on
masterduring the lifetime of the branch.Tested this with the CircleCI checkout script and it worked as expected (only 6 files changed for that build). Earlier tests did non run on long living branches.