Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chip] Add onKeyUp handler for correct behavior #12660

Merged
merged 2 commits into from Aug 25, 2018
Merged

[Chip] Add onKeyUp handler for correct behavior #12660

merged 2 commits into from Aug 25, 2018

Conversation

markselby9
Copy link
Contributor

Add a onKeyUp handler and move onClick callback into it.

Fix: #12449

@markselby9
[Chip] Add onKeyUp handler for correct behavior (mui#12449)
110b677 
Add a onKeyUp handler and move onClick callback into it.

Fix: mui#12449
@oliviertassinari oliviertassinari self-assigned this Aug 25, 2018
@oliviertassinari oliviertassinari added component: chip This is the name of the generic UI component, not the React module! new feature New feature or request labels Aug 25, 2018
@oliviertassinari oliviertassinari changed the title [Chip] Add onKeyUp handler for correct behavior (#12449) [Chip] Add onKeyUp handler for correct behavior Aug 25, 2018
@oliviertassinari oliviertassinari merged commit 12ec275 into mui:master Aug 25, 2018
@oliviertassinari
Copy link
Member

@markselby9 Thank you!

@markselby9 markselby9 deleted the fix-12449 branch August 26, 2018 09:28
marcelpanse pushed a commit to marcelpanse/material-ui that referenced this pull request Oct 2, 2018
@markselby9 @marcelpanse
[Chip] Add onKeyUp handler for correct behavior (mui#12660)
8572a35 
* [Chip] Add onKeyUp handler for correct behavior (mui#12449)

Add a onKeyUp handler and move onClick callback into it.

Fix: mui#12449

* let's merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oliviertassinari oliviertassinari

Labels
component: chip This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@markselby9 @oliviertassinari