[examples] Fix withRoot accepting any props #12713
Conversation
| @@ -2,4 +2,4 @@ import * as React from 'react'; | |||
| import * as ReactDOM from 'react-dom'; | |||
| import Index from './pages/index'; | |||
|
|
|||
| ReactDOM.render(<Index />, document.querySelector('#root')); | |||
| ReactDOM.render(<Index projectName="Hello, World!" />, document.querySelector('#root')); | |||
There was a problem hiding this comment.
I think that providing a property here is an edge case. Do we need to complexify the example?
There was a problem hiding this comment.
A component with props is one of the core use cases of components, no? Especially since this example should be used for issues I think that we should have a proper scaffold for props usage.
So for me this is the most basic usage of components and not some complex example. I would even argue that state and event handling (which is used in the example) is far more complex than simple props.
Providing props at this point is uncommon, yes. We could refactor this to have a dumb wrapper around index but I can't see any benefit.
There was a problem hiding this comment.
Providing props at this point is uncommon
It's exactly my concern. I think that it's better to support it but not actually implementing it.
eps1lon
force-pushed
the
fix-cra-ts-example
branch
from
2b311fb
to
3672b17
Compare
As a followup to #12712 this includes actual props which revealed that the previous work was incomplete. The generic argument was not defined. The sandbox just emits javascript anyway although typescript displays errors.
I also went ahead and switch from
typetointerfaceforStatewhich is a recommended tslint rule.