Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Clean up create-react-app-with-typescript #12992

Merged
merged 2 commits into from
Sep 24, 2018
Merged

[examples] Clean up create-react-app-with-typescript #12992

merged 2 commits into from
Sep 24, 2018

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 24, 2018

  • removes unused definitions (cuts down noise)
  • newer react-scripts-ts require tsconfig.prod.json for build step

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation typescript labels Sep 24, 2018
@oliviertassinari oliviertassinari merged commit 7d2fadf into mui:master Sep 24, 2018
@eps1lon eps1lon deleted the examples/cra-ts/cleanup branch September 24, 2018 20:39
marcelpanse pushed a commit to marcelpanse/material-ui that referenced this pull request Oct 2, 2018
@eps1lon @marcelpanse
[examples] Clean up create-react-app-with-typescript (mui#12992)
48dd769 
* [examples] Remove unused ts definitions

* [examples] FIx yarn build throwing in with-typescript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eps1lon @oliviertassinari