[core] Upgrade the dev dependencies #13016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
upgrade-dev-dependencies-v10
branch
from
9cbbc4d
to
18a696b
Compare
|
Is anything holding back |
| window.ga('send', { | ||
| hitType: 'pageview', | ||
| this.timer = setTimeout(() => { | ||
| window.ga('set', { |
There was a problem hiding this comment.
As suggested in the G.A. docs so future events have the right context.
| @@ -1,29 +1,29 @@ | |||
| import React from 'react'; | |||
|
|
|||
| class GoogleTag extends React.Component { | |||
| googleTimer = null; | |||
| class GoogleAnalytics extends React.Component { | |||
There was a problem hiding this comment.
Google tag manager makes two HTTP requests, Google analytics makes one.
|
@eps1lon We have that in the yarn.lock. next@^7.0.0-canary.0:
- version "7.0.0-canary.18"
- resolved "https://registry.yarnpkg.com/next/-/next-7.0.0-canary.18.tgz#7811b8511232ae96b71e34663ed20f4d41fa87af"
+ version "7.0.0"
+ resolved "https://registry.yarnpkg.com/next/-/next-7.0.0.tgz#c919b325fbce21b6a1d6cd1cc0be148540e77bfd"You are right, we can upgrade the package.json, no need to stay on canny. I think that we where using canary to leverage babel 7. It's stabe now, we can go back to the non cannary releaes to avoid fast changing regressions. |
oliviertassinari
force-pushed
the
upgrade-dev-dependencies-v10
branch
from
18a696b
to
124bfaa
Compare
marcelpanse
pushed a commit
to marcelpanse/material-ui
that referenced
this pull request
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.