[core] Remove redundant class field initializers, save 1% of bundle size #13022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
|
I'm gonna be way more greedy 😈, I'm pushing this pull request further. |
oliviertassinari
force-pushed
the
remove-reduntant-null-init-in-class-fields
branch
from
394e58d
to
d3c0dcf
Compare
| @@ -22,13 +22,13 @@ module.exports = [ | |||
| name: 'The size of all the modules of material-ui.', | |||
| webpack: true, | |||
| path: 'packages/material-ui/build/index.js', | |||
| limit: '92.4 KB', | |||
| limit: '91.4 KB', | |||
There was a problem hiding this comment.
The best part, 1% reduction 😎
oliviertassinari
approved these changes
Sep 27, 2018
|
@RobertPurcea Thank you! 🚀 |
oliviertassinari
changed the title
marcelpanse
pushed a commit
to marcelpanse/material-ui
that referenced
this pull request
Oct 2, 2018
* remove redundant class field initializers, if they are overwritten in constructor * bundle size\!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several components where assignments in the constructor overwrite class fields assignments making them redundant.