[Dialog] Fix dialog maxHeight math. #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* paddingTop is already a function of clientHeight (and the Dialog's own current height). Among other things, this makes it impossible for the Dialog's maxHeight to ever reduce; demonstrated by resizing window down and back up (Dialog stays tiny). Also, this made it impossible for the Dialog to grow in response to changing dimensions of its rendered children.
hai-cea
added a commit
that referenced
this pull request
Aug 3, 2015
[Dialog] Fix dialog maxHeight math.
|
Thanks @igrayson 👍 |
zannager
added
the
component: dialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
own current height). Among other things, this makes it impossible
for the Dialog's maxHeight to ever reduce; demonstrated by
resizing window down and back up (Dialog stays tiny). Also,
this made it impossible for the Dialog to grow in response
to changing dimensions of its rendered children.