-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @types/jss and update to latest jss dependencies #14048
Conversation
This reverts commit 694fe85.
@oliviertassinari please take a look at the build errors
I do believe we should try and release this as a hotfix asap. |
Good/related question in cssinjs/jss#964 (comment) - if we don't want the public release of mui using jss alpha release, we should close this and take a different tact, namely reverting type changes on |
@@ -48,13 +47,13 @@ | |||
"dom-helpers": "^3.2.1", | |||
"hoist-non-react-statics": "^3.2.1", | |||
"is-plain-object": "^2.0.4", | |||
"jss": "^9.8.7", | |||
"jss-camel-case": "^6.0.0", | |||
"jss": "^10.0.0-alpha.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very ambitious. I doubt it will simplify the situation. Instead, I would try to better isolate material-ui/styles from material-ui/core/styles.
I'm closing - I'm not in favor of pushing into alpha a our public dependency. |
Closes #14040
Also
unrelated build config updates (also extracted to #14050):
--frozen-lockfile
to avoid diff between repo and ci runsCheck versions and env
step