Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @types/jss and update to latest jss dependencies #14048

Closed
wants to merge 6 commits into from

Conversation

rosskevin
Copy link
Member

@rosskevin rosskevin commented Dec 31, 2018

Closes #14040

Also

unrelated build config updates (also extracted to #14050):

  • use --frozen-lockfile to avoid diff between repo and ci runs
  • update the yarn cache to that reported by the cli in the Check versions and env step

@rosskevin
Copy link
Member Author

rosskevin commented Dec 31, 2018

@oliviertassinari please take a look at the build errors

  • size bump may be jss related to dep version changes. I don't want to make the call on those.
  • eslint errors - no idea why a jss dep update would be affecting those, must be new yarn.lock related?

I do believe we should try and release this as a hotfix asap.

@rosskevin
Copy link
Member Author

Good/related question in cssinjs/jss#964 (comment) - if we don't want the public release of mui using jss alpha release, we should close this and take a different tact, namely reverting type changes on createGenerateClasseName.d.ts and jssPreset.d.ts and withStyles.d.ts instead to be using @types/jss.

@@ -48,13 +47,13 @@
"dom-helpers": "^3.2.1",
"hoist-non-react-statics": "^3.2.1",
"is-plain-object": "^2.0.4",
"jss": "^9.8.7",
"jss-camel-case": "^6.0.0",
"jss": "^10.0.0-alpha.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very ambitious. I doubt it will simplify the situation. Instead, I would try to better isolate material-ui/styles from material-ui/core/styles.

@rosskevin
Copy link
Member Author

I'm closing - I'm not in favor of pushing into alpha a our public dependency.

@rosskevin rosskevin closed this Dec 31, 2018
@rosskevin rosskevin deleted the ts-fix-jss-types branch January 25, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants