Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add gadr.io in the showcase #14128

Merged
merged 2 commits into from Jan 11, 2019
Merged

Conversation

clabbeaf
Copy link
Contributor

@clabbeaf clabbeaf commented Jan 9, 2019

Hi,

I would like to submit a new showcase for gadr.io.
Keep up the good work, big fan of MUI

/Hans

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 9, 2019

@clabbeaf Well done with this project and thank you for taking the time to open a pull-request! However, we start to have a lot of projects in the showcase. We are focusing on high traffic websites using Material-UI. I fear that we will reject this change.

@eps1lon
Copy link
Member

eps1lon commented Jan 10, 2019

@oliviertassinari Maybe showcase only "big players" with an image and a simple list for others (if the page is open source)? I think there is some value in collecting as much "callsites" as possible so that we can collect common use cases.

@mbrookes
Copy link
Member

mbrookes commented Jan 10, 2019

I don't have an issue with continuing to add sites for the time being (I have another 20 or so to add). We have quite a few others on the list with lower traffic than gadr.io.

If the page length becomes a problem, then we could always have a "top ten" or top twenty", and move the rest to a grid-list, but if all someone is interested in is the top sites, well, they're already at the top, so they can just stop scrolling. 😄

docs/src/pages/discover-more/showcase/Showcase.js Outdated Show resolved Hide resolved
docs/src/pages/discover-more/showcase/Showcase.js Outdated Show resolved Hide resolved
docs/src/pages/discover-more/showcase/Showcase.js Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari changed the title Showcase gadr.io [docs] Add gadr.io in the showcase Jan 11, 2019
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jan 11, 2019
@clabbeaf
Copy link
Contributor Author

Thanks.
Did you want me to make the changes posted before?
Saw that the image was removed, was that intentional?

@oliviertassinari
Copy link
Member

Let's wait @mbrookes feedback on the change. Yes, I have removed 4 project images.

@clabbeaf
Copy link
Contributor Author

Ok.
Do you want another image with more material UI components visible or why was it removed?

@clabbeaf
Copy link
Contributor Author

We're launching right now so there will (hopefully :) ) be more traffic soon. Would really appriciate if we could be more visible on the site.
And we have really gone all in with material UI components

@oliviertassinari oliviertassinari merged commit 598132f into mui:master Jan 11, 2019
@oliviertassinari
Copy link
Member

@clabbeaf Good luck with this project :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants