[core] Remove unnecessary rules in .eslintrc #14173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WebDeg-Brian It doesn't work. However @joshwooding has raised an important concern for Windows users We need to add this rule back 35fd3b8#diff-e4403a877d80de653400d88d85e4801aL30. I was too greedy. |
|
@oliviertassinari ah yes that killer rule. Is there a reason that I can no longer update the file? I removed those and everything works fine on my end. |
eps1lon
previously requested changes
Jan 13, 2019
|
@eps1lon I might as well close and investigate this a bit further. I didn't understand why as soon as I committed the changes the unit tests failed. |
|
@WebDeg-Brian I'm rebasing. |
oliviertassinari
force-pushed
the
eslint-simplification
branch
from
22cbf71
to
3c2b6d9
Compare
|
I have found a fix. |
oliviertassinari
approved these changes
Jan 13, 2019
|
@oliviertassinari Awesome! |
joshwooding
reviewed
Jan 13, 2019
joshwooding
approved these changes
Jan 13, 2019
|
@oliviertassinari Thank you! |
WebDeg-Brian
added a commit
to WebDeg-Brian/material-ui
that referenced
this pull request
Jan 14, 2019
This reverts commit 733c694.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove rules that have been turned off by
eslint-config-prettier