Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Remove unneeded input from select docs #14443

Merged
merged 2 commits into from Feb 7, 2019
Merged

[docs] Remove unneeded input from select docs #14443

merged 2 commits into from Feb 7, 2019

Conversation

eladmotola
Copy link
Contributor

@eladmotola eladmotola commented Feb 6, 2019 •
edited by oliviertassinari

Closes #14442

@eladmotola eladmotola mentioned this pull request Feb 6, 2019
Closed
@eladmotola eladmotola changed the title remove unneeded inputlabel at select docs [Docs]remove unneeded inputlabel at select docs Feb 6, 2019
@joshwooding joshwooding changed the title [Docs]remove unneeded inputlabel at select docs [docs] Remove customized InputBase from customized Select demo Feb 6, 2019
@joshwooding joshwooding added the docs Improvements or additions to the documentation label Feb 6, 2019
@oliviertassinari oliviertassinari self-assigned this Feb 7, 2019
@oliviertassinari oliviertassinari changed the title [docs] Remove customized InputBase from customized Select demo [docs] Remove unneeded inputlabel at select docs Feb 7, 2019
@oliviertassinari oliviertassinari removed their assignment Feb 7, 2019
@oliviertassinari oliviertassinari changed the base branch from master to next February 7, 2019 10:00
@oliviertassinari oliviertassinari changed the base branch from next to master February 7, 2019 10:01
@oliviertassinari oliviertassinari changed the base branch from master to next February 7, 2019 10:02
@joshwooding joshwooding changed the title [docs] Remove unneeded inputlabel at select docs [docs] Remove unneeded input from select docs Feb 7, 2019
@joshwooding joshwooding merged commit acc8a32 into mui:next Feb 7, 2019
@joshwooding
Copy link
Member

@eladmotola It's a great first pull request on Material-UI 🎉 . Thank you for working on it!

@eladmotola
Copy link
Contributor Author

hey @joshwooding and @oliviertassinari !
my changes has been reverted somehow.... check this out:
https://next.material-ui.com/demos/selects/#customized-selects

@oliviertassinari
Copy link
Member

oliviertassinari commented May 11, 2019 •
edited

@eladmotola It was probably lost during the TypeScript migration. I'm happy to keep the demo as they are. We first show how to customize the input, then the select.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] The first select at "Customized selects" section is not a select
3 participants
@eladmotola @joshwooding @oliviertassinari