Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Run the TypeScript demos #15159

Merged
merged 4 commits into from Apr 3, 2019

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Apr 2, 2019

This change is running the TypeScript demos when the code variant is selected. It will significantly improve the workflow. Now, we can iterate on the TypeScript demo variants FIRST, then run docs:typescript:formatted. We do no longer have to worry about the JavaScript demos.

I have only migrated the snackbar

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation typescript labels Apr 2, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 2, 2019

Details of bundle changes.

Comparing: 240dc18...906df8f

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 349,839 349,839 89,879 89,879
@material-ui/core/Paper 0.00% 0.00% 67,853 67,853 19,820 19,820
@material-ui/core/Paper.esm 0.00% 0.00% 60,184 60,184 18,563 18,563
@material-ui/core/Popper 0.00% 0.00% 30,463 30,463 10,530 10,530
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 17,364 17,364 5,726 5,726
@material-ui/core/useMediaQuery 0.00% 0.00% 2,469 2,469 1,041 1,041
@material-ui/lab 0.00% 0.00% 147,758 147,758 43,621 43,621
@material-ui/styles 0.00% 0.00% 53,105 53,105 15,433 15,433
@material-ui/system 0.00% 0.00% 17,136 17,136 4,525 4,525
Button 0.00% 0.00% 87,927 87,927 26,054 26,054
Modal 0.00% 0.00% 82,035 82,035 24,552 24,552
colorManipulator 0.00% 0.00% 3,232 3,232 1,299 1,299
docs.landing 0.00% 0.00% 49,899 49,899 10,803 10,803
docs.main +0.02% 🔺 0.00% 645,314 645,433 200,459 200,465
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 298,242 298,242 82,697 82,697

Generated by 🚫 dangerJS against 906df8f

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. With this change yarn docs:typescript isn't useful anymore. We can merge it later into docs/scripts/formattedTSDemos.

docs/src/modules/components/Demo.js Show resolved Hide resolved
pages/demos/snackbars.js Show resolved Hide resolved
@oliviertassinari
Copy link
Member Author

We should be good now.

@oliviertassinari oliviertassinari merged commit 81e82b0 into mui:next Apr 3, 2019
@oliviertassinari oliviertassinari deleted the typescript-live-demos branch February 8, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants