-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Run the TypeScript demos #15159
Merged
oliviertassinari
merged 4 commits into
mui:next
from
oliviertassinari:typescript-live-demos
Apr 3, 2019
Merged
[docs] Run the TypeScript demos #15159
oliviertassinari
merged 4 commits into
mui:next
from
oliviertassinari:typescript-live-demos
Apr 3, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
Improvements or additions to the documentation
typescript
labels
Apr 2, 2019
oliviertassinari
force-pushed
the
typescript-live-demos
branch
from
April 2, 2019 11:31
a8dd587
to
308a45d
Compare
oliviertassinari
force-pushed
the
typescript-live-demos
branch
from
April 2, 2019 11:33
308a45d
to
df9062a
Compare
Details of bundle changes.Comparing: 240dc18...906df8f
|
eps1lon
reviewed
Apr 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. With this change yarn docs:typescript
isn't useful anymore. We can merge it later into docs/scripts/formattedTSDemos
.
We should be good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is running the TypeScript demos when the code variant is selected. It will significantly improve the workflow. Now, we can iterate on the TypeScript demo variants FIRST, then run
docs:typescript:formatted
. We do no longer have to worry about the JavaScript demos.I have only migrated the snackbar