Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Proof the Styles section #15268

Merged
merged 3 commits into from Apr 9, 2019
Merged

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Apr 9, 2019

(with apologies to our translators for the overhead 馃槄)

(with apologies to our translators for the overhead 馃槄)
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 9, 2019

No bundle size changes comparing 5bbf156...0fda4eb

Generated by 馃毇 dangerJS against 0fda4eb

@mbrookes
Copy link
Member Author

mbrookes commented Apr 9, 2019

Also, "stress test"?

@joshwooding
Copy link
Member

Also, "stress test"?

?

@eps1lon
Copy link
Member

eps1lon commented Apr 9, 2019

Also, "stress test"?

?

It's referring to https://next--material-ui.netlify.com/css-in-js/basics/#stress-test.

I agree that this is a misnomer currently. That section isn't testing the solution under heavy load nor is it asserting when the solution should fail.

It is showcasing the combination of theme and props based styles. Maybe "Combine theme and props based styles"?

That section could also be improved from a usability standpoint. The dialog is blocking everything (including tab switch) until I pressed the tiny "X" to close it.

@eps1lon eps1lon added the docs Improvements or additions to the documentation label Apr 9, 2019
docs/src/pages/css-in-js/advanced/advanced.md Outdated Show resolved Hide resolved
docs/src/pages/css-in-js/basics/basics.md Outdated Show resolved Hide resolved
docs/src/pages/css-in-js/basics/basics.md Outdated Show resolved Hide resolved
@oliviertassinari
Copy link
Member

That section isn't testing the solution under heavy load nor is it asserting when the solution should fail.

To defend my church: This is a demo that people can use to "stress test" the solution. The values can update at 60 FPS. I'm happy to remove/revisit it.

joshwooding and others added 2 commits April 9, 2019 12:51
Co-Authored-By: mbrookes <github@nospam.33m.co>
Co-Authored-By: mbrookes <github@nospam.33m.co>
@eps1lon
Copy link
Member

eps1lon commented Apr 9, 2019

The values can update at 60 FPS.

How? I for one can't change the values with the current solution 60 times per second with my mouse.

@oliviertassinari
Copy link
Member

@eps1lon Like this:

Apr-09-2019 14-01-54

@mbrookes mbrookes merged commit 784c0a2 into mui:next Apr 9, 2019
@mbrookes mbrookes deleted the docs-proof-styles branch April 9, 2019 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants