[utils] Fix lazy and memo components issuing forward ref warnings #15322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
eps1lon
commented
Apr 11, 2019
| function assertPass(Component, options = {}) { | ||
| const { failsOnMount = false, shouldMount = true } = options; | ||
|
|
||
| checkPropType(Component); | ||
| if (shouldMount) { | ||
| mount(<Component ref={React.createRef()} />); | ||
| ReactDOM.render( | ||
| <React.Suspense fallback={<p />}> |
There was a problem hiding this comment.
enzyme doesn't understand Suspense yet (Unknown tag 13).
|
@material-ui/core: parsed: +Infinity% , gzip: +Infinity% Details of bundle changes.Comparing: 6a6e360...ad2289d
|
eps1lon
force-pushed
the
fix/utils/elements-accepting-refs
branch
from
50165fa
to
ad2289d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React.lazyandReact.memoare thin wrappers. The ref is automatically forwarded to the inner component. This can potentially hide ref warnings but we don't have proper tools for introspection.