New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SelectInput] Convert to function component #15410
[SelectInput] Convert to function component #15410
Conversation
@material-ui/core: parsed: -0.26% 😍, gzip: -0.17% 😍 Details of bundle changes.Comparing: 3044cb4...b175c50
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! I have tried something new with this review: 1. Checkout the pull request. 2. Revert the source back to its original state. 3. Make sure the new tests are green.
I try to do this when re-writing the tests :) |
This is something I'll try to do with all my PRs: Tests before implementation. This way it's easier for reviewers to verify: is it a bug? would this test new behavior properly etc. Then you can share different implementations based on the same test plan via git branches. If you do impl after test this becomes very weird (hard reset, rebase etc). |
Works towards #15231