[ClickAwayListener] Hide react-event-listener #15420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
breaking change
component: ClickAwayListener
During the refactor to hooks I'm removing EventListener where I can in favour of hooks |
Details of bundle changes.Comparing: f132c3c...e510c1e
|
oliviertassinari
force-pushed
the
hide-react-event-listener
branch
from
d3313d7
to
e510c1e
Compare
56 tasks
eps1lon
approved these changes
Apr 20, 2019
| @@ -114,6 +114,11 @@ ClickAwayListener.propTypes = { | |||
| touchEvent: PropTypes.oneOf(['onTouchStart', 'onTouchEnd', false]), | |||
| }; | |||
|
|
|||
| if (process.env.NODE_ENV !== 'production') { | |||
| // eslint-disable-next-line | |||
| ClickAwayListener['propTypes' + ''] = exactProp(ClickAwayListener.propTypes); | |||
There was a problem hiding this comment.
Guess this tricks babel-plugin-remove-prop-types?
There was a problem hiding this comment.
Yes, you are correct. While I didn't try without it in this specific case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15126
The new react hooks API makes the usage of react-event-listener less interesting. I think that it would be great to remove this dependency. It might yield a small bundle size gain (0.7 KB gzipped): https://bundlephobia.com/result?p=react-event-listener@0.6.6.