Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve CSS Grid documentation #15477

Merged
merged 2 commits into from Apr 25, 2019
Merged

Conversation

dmwyatt
Copy link
Contributor

@dmwyatt dmwyatt commented Apr 24, 2019

As discussed in #9513 starting at #9513 (comment) the current documentation was a little confusing and not really located in a logical place.

I'm not sure there is a logical place for this information, but it seems like the end of the document is better than in the middle of information talking about grid stuff that MUI does support.

I made the fact that Material UI doesn't provide any CSS Grid functionality explicit.

I also took out the warning about CSS Grid only being supported in the latest browsers. As of right now it has 90% browser coverage at https://caniuse.com/#feat=css-grid.

As discussed in mui#9513 starting at mui#9513 (comment) the current documentation was a little confusing and not really located in a logical place.

I'm not sure there *is* a logical place for this information, but it seems like the end of the document is better than in the middle of information talking about grid stuff that MUI *does* support.

I made the fact that Material UI doesn't provide any CSS Grid functionality explicit.

I also took out the warning about CSS Grid only being supported in the latest browsers.  As of right now it has 90% browser coverage at https://caniuse.com/#feat=css-grid.
@dmwyatt dmwyatt changed the title Better (?) CSS Grid documentation [docs] Improve CSS Grid documentation Apr 24, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 24, 2019

No bundle size changes comparing d1df9a8...d4585ac

Generated by 🚫 dangerJS against d4585ac

@oliviertassinari oliviertassinari merged commit 11c8ec6 into mui:next Apr 25, 2019
@oliviertassinari
Copy link
Member

Thanks

@zannager zannager added docs Improvements or additions to the documentation component: Grid The React component. labels Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Grid The React component. docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants