Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Migrate more demos to hooks #15494

Merged
merged 21 commits into from Apr 29, 2019
Merged

[docs] Migrate more demos to hooks #15494

merged 21 commits into from Apr 29, 2019

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Apr 25, 2019 •
edited

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 25, 2019 •
edited

No bundle size changes comparing f1e89c3...6d021d3

Generated by 🚫 dangerJS against 6d021d3

@merceyz merceyz mentioned this pull request Apr 25, 2019
Merged
1 task
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Apr 26, 2019
@merceyz merceyz marked this pull request as ready for review April 27, 2019 00:28
@merceyz merceyz changed the title [docs] Migrate batch of demos to hooks [docs] Migrate the rest of typescript demos to hooks Apr 27, 2019
@merceyz
Copy link
Member Author

merceyz commented Apr 27, 2019

There are 3 class demos left, will take those tomorrow

@eps1lon eps1lon self-requested a review April 27, 2019 08:11
oliviertassinari
oliviertassinari reviewed Apr 27, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@merceyz I understand you want to do one big pull request. However, I think that it's better to do it incrementally a 1k LOCs changes seems to be a good threshold to split the effort. I will ease the review experience for us and prevent conflicts for you.
Capture d’écran 2019-04-27 à 13 10 53

@oliviertassinari oliviertassinari added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Apr 27, 2019
@merceyz merceyz changed the title [docs] Migrate the rest of typescript demos to hooks [docs] Migrate more typescript demos to hooks Apr 27, 2019
@oliviertassinari
Copy link
Member

@merceyz We have conflict. I'm rebasing. It's time to merge it :).

merceyz and others added 16 commits April 29, 2019 11:04
@oliviertassinari oliviertassinari self-assigned this Apr 29, 2019
@oliviertassinari oliviertassinari changed the title [docs] Migrate more typescript demos to hooks [docs] Migrate more demos to hooks Apr 29, 2019
@oliviertassinari
Copy link
Member

@merceyz I have reverted a 3 ambitious changes that were creating conflicts and build fails. You can find them in:

They might require individual pull requests.

@oliviertassinari oliviertassinari merged commit 8c5a1ca into mui:next Apr 29, 2019
@oliviertassinari
Copy link
Member

@merceyz Thank you!

@merceyz merceyz deleted the docs/hooks branch April 29, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@eps1lon eps1lon eps1lon left review comments

@joshwooding joshwooding joshwooding left review comments

Assignees

@oliviertassinari oliviertassinari

Labels
docs Improvements or additions to the documentation PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@merceyz @mui-pr-bot @oliviertassinari @eps1lon @joshwooding