Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs] Fix aria-label issue on the demos #15507

Merged
merged 3 commits into from Apr 29, 2019
Merged

[Tabs] Fix aria-label issue on the demos #15507

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9a0c8c
[Tabs] Update with aria-label attribute
amangalvedhekar Apr 27, 2019
49b183a
Fix Wave accessibility issues
oliviertassinari Apr 27, 2019
f0b84b8
need further discussion
oliviertassinari Apr 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/material-ui/src/Tabs/TabScrollButton.js
View file
Open in desktop
Expand Up @@ -28,7 +28,14 @@ const TabScrollButton = React.forwardRef(function TabScrollButton(props, ref) {
}

return (
<ButtonBase className={className} onClick={onClick} ref={ref} tabIndex={-1} {...other}>
<ButtonBase
aria-label={direction}
className={className}
onClick={onClick}
ref={ref}
tabIndex={-1}
{...other}
>
{direction === 'left' ? <KeyboardArrowLeft /> : <KeyboardArrowRight />}
</ButtonBase>
);
Expand Down