[docs] Fix outdated links & demos #15521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -89,8 +89,8 @@ const styles = theme => ({ | |||
| display: 'block', | |||
| padding: 4, | |||
| textAlign: 'center', | |||
| backgroundColor: '#0a6fc2', | |||
| color: 'white', | |||
| backgroundColor: theme.palette.primary.dark, | |||
| @@ -108,7 +108,7 @@ const styles = theme => ({ | |||
| duration: theme.transitions.duration.leavingScreen, | |||
| }), | |||
| left: theme.spacing(2), | |||
| top: theme.spacing(-6), | |||
| top: theme.spacing(-10), | |||
There was a problem hiding this comment.
Move the banner higher so we don't see it when we scroll
| @@ -354,6 +355,7 @@ class Demo extends React.Component { | |||
| className={clsx(classes.demo, { | |||
| [classes.demoHiddenHeader]: demoOptions.hideHeader, | |||
| })} | |||
| tabIndex={-1} | |||
There was a problem hiding this comment.
Make testing the tab behavior easier. Otherwise, the focus moves to the <main> element.
| @@ -150,4 +150,3 @@ For more advanced use cases you might be able to take advantage of: | |||
| - [redux-form-material-ui](https://github.com/erikras/redux-form-material-ui) A set of wrapper components to facilitate using Material UI with Redux Form. | |||
| - [formik-material-ui](https://github.com/stackworx/formik-material-ui) Bindings for using Material-UI with formik. | |||
| - [final-form-material-ui](https://github.com/Deadly0/final-form-material-ui) A set of wrapper components to facilitate using Material UI with Final Form. | |||
| - [uniforms-material](https://github.com/vazco/uniforms/tree/master/packages/uniforms-material) Material-UI wrapper components for Uniforms, a set of React libraries for building forms. | |||
There was a problem hiding this comment.
Has no traction
| @@ -1,4 +1,4 @@ | |||
| ## Supporting Material-UI | |||
| <h2 align="center">Supporting Material-UI</h2> | |||
There was a problem hiding this comment.
Consistency with the "Who is using?"
| <NoSsr> | ||
| <Container className={classes.container}> | ||
| <Container maxWidth="md" className={classes.container}> |
There was a problem hiding this comment.
Consistency with the backers.
| @@ -58,7 +58,7 @@ Explicitly providing the class names to the component is too much effort? | |||
|
|
|||
| **GlobalCssButton.css** | |||
| ```css | |||
| .MuiButton { | |||
| .MuiButton-root { | |||
| @@ -144,7 +144,7 @@ Another approach is to use the `&&` characters in styled-components to [bump up | |||
| If you attempt to style a Drawer with variant permanent, | |||
| you will likely need to affect the Drawer's child paper element. | |||
| However, the paper is not the root element of Drawer and therefore styled-components customization as above will not work. | |||
| You need to use the [`classes`](/css-in-js/advanced/#classes) API of Material-UI. | |||
| You need to use the [`classes`](/css-in-js/advanced/#overriding-styles-classes-prop) API of Material-UI. | |||
Details of bundle changes.Comparing: c867c5f...793ad23
|
joshwooding
approved these changes
Apr 29, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.