[test] Extend StrictMode tests #15714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Already tested in describeConformance
strictMode renders twice
Some tests were redundant Some used text() which uses findDOMNode
eps1lon
commented
May 15, 2019
| assert.lengthOf(nextButton.find('svg[data-mui-test="KeyboardArrowRightIcon"]'), 1); | ||
| }); | ||
|
|
||
| it('should render backButton custom text', () => { |
There was a problem hiding this comment.
This tests the same as should render next button. Both specify a nextButton prop.
eps1lon
commented
May 15, 2019
| ); | ||
| }); | ||
|
|
||
| it('should render disabled backButton', () => { |
There was a problem hiding this comment.
This is testing Button instead of MobileStepper.
|
No bundle size changes comparing 6dbe568...a0dbc66 |
oliviertassinari
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify if StrictMode compatible or not on the remaining tests.
findHostNodeSomehow(wrapper).instance().textContentis a StrictMode compatible alternative towrapper.text().