[docs] Move links to the master branch #15830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
oliviertassinari
force-pushed
the
next-to-master
branch
from
47ed458
to
66b334e
Compare
Details of bundle changes.Comparing: ef18a5d...a966a24
|
oliviertassinari
force-pushed
the
next-to-master
branch
from
0af469e
to
a966a24
Compare
mbrookes
requested changes
May 24, 2019
| "/Users/oliviertassinari/preact-next/node_modules/jest-watch-typeahead/filename.js", | ||
| "/Users/oliviertassinari/preact-next/node_modules/jest-watch-typeahead/testname.js" | ||
| "/Users/oliviertassinari/preact/node_modules/jest-watch-typeahead/filename.js", | ||
| "/Users/oliviertassinari/preact/node_modules/jest-watch-typeahead/testname.js" |
|
|
||
| We will do our best to keep `next` in good shape, with tests passing at all times. | ||
| We will do our best to keep `master` in good shape, with tests passing at all times. | ||
| However, in order to move fast, we will make API changes that your application might not be compatible with. |
There was a problem hiding this comment.
Oh no, we don't 🙏!
| ### How to increase the chance of being accepted? | ||
|
|
||
| We will only accept a pull request for which all tests pass. Make sure the following is true: | ||
| - The branch is targeted at: | ||
| - `master` for important fixes. | ||
| - `next` for everything else including breaking changes. | ||
| - `master` for ongoing development. | ||
| - The branch is not behind its target. | ||
| - If a breaking change is introduced: |
|
Merging and deploying. I'm running a 3rd SEO crawl. |
|
It's a shame github doesn't notify you when attempting to merge a PR with an in-progress review. |
|
😢. At least, it's not lost, could you open a pull request? I suspect we will uncover more problems in the coming days. |
|
What should this be instead? "watchPlugins": [
"/Users/oliviertassinari/preact/node_modules/jest-watch-typeahead/filename.js",
"/Users/oliviertassinari/preact/node_modules/jest-watch-typeahead/testname.js"
] |
|
I would say, that we can remove this JSON key. Well spotted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nextbranch, we need to change the links to point to the master branch