Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Link] Better support of component="button" #15863

Merged
merged 5 commits into from May 31, 2019
Merged

[Link] Better support of component="button" #15863

merged 5 commits into from May 31, 2019

Conversation

ianschmitz
Copy link
Contributor

Fixes #15840.

This PR resets the outline styling to auto when keyboard focusing a Link component that is configured to render using a button element.

@mui-pr-bot
Copy link

mui-pr-bot commented May 26, 2019 •
edited

@material-ui/core: parsed: +0.10% , gzip: +0.13%

Details of bundle changes.

Comparing: 831c6cc...7e3a2fc

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.10% 🔺 +0.13% 🔺 315,057 315,386 86,304 86,419
@material-ui/core/Paper 0.00% -0.00% 67,921 67,921 20,184 20,183
@material-ui/core/Paper.esm 0.00% -0.02% 61,217 61,217 18,981 18,977
@material-ui/core/Popper 0.00% 0.00% 28,740 28,740 10,345 10,345
@material-ui/core/Textarea 0.00% +0.08% 🔺 5,513 5,513 2,376 2,378
@material-ui/core/TrapFocus 0.00% 0.00% 3,744 3,744 1,573 1,573
@material-ui/core/styles/createMuiTheme 0.00% -0.02% 15,978 15,978 5,787 5,786
@material-ui/core/useMediaQuery 0.00% -0.10% 2,106 2,106 975 974
@material-ui/lab 0.00% +0.03% 🔺 138,866 138,866 42,660 42,674
@material-ui/styles 0.00% 0.00% 51,386 51,386 15,193 15,193
@material-ui/system 0.00% -0.05% 14,463 14,463 4,181 4,179
Button 0.00% +0.03% 🔺 83,901 83,901 25,459 25,467
Modal 0.00% -0.01% 20,343 20,343 6,685 6,684
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 55,977 55,977 14,042 14,042
docs.main +0.06% 🔺 +0.08% 🔺 648,947 649,337 204,664 204,829
packages/material-ui/build/umd/material-ui.production.min.js +0.10% 🔺 +0.15% 🔺 293,979 294,276 83,766 83,890

Generated by 🚫 dangerJS against 7e3a2fc

@oliviertassinari oliviertassinari changed the title Add focus style when keyboard focusing Button Link [Link] Better support of component="button" May 26, 2019
@oliviertassinari oliviertassinari added component: link This is the name of the generic UI component, not the React module! PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels May 26, 2019
oliviertassinari
oliviertassinari approved these changes May 29, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I have rebased on the master branch and removed two usages of shallow to mount.
A second 👀 would be perfect.

@ianschmitz
Copy link
Contributor Author

Looks good to me. Thanks @oliviertassinari!

@oliviertassinari oliviertassinari merged commit d314cc4 into mui:master May 31, 2019
@oliviertassinari
Copy link
Member

Thanks

@ianschmitz ianschmitz deleted the button-link-a11y branch June 5, 2019 00:41
@aditya1906 aditya1906 mentioned this pull request Jun 10, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
accessibility a11y component: link This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button Link missing keyboard focus style
4 participants
@ianschmitz @mui-pr-bot @oliviertassinari @eps1lon