[Container] Document the classes API #15919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 831c6cc...d2ee5ac |
|
@divyanshutomar I'm sorry, I don't understand how #15919 is different to #15872. They are both breaking changes. I'm doing a bit of changes. I have labeled #15872 for v5 (we can probably merge it around Q1 2020). Now, let's keep this one for adding the missing documentation :). I'm updating it. |
oliviertassinari
changed the title
oliviertassinari
added
docs
oliviertassinari
force-pushed
the
container/gutters-class
branch
from
30160da
to
d2ee5ac
Compare
oliviertassinari
approved these changes
May 29, 2019
|
@oliviertassinari Sorry, I guess I misunderstood the breaking change. Anyway, this looks good to go! I will update the previous PR once this is merged. |
joshwooding
approved these changes
May 30, 2019
|
@divyanshutomar Thanks 👍 It’s always great to see documentation improvements. |
|
@divyanshutomar The breaking change is for people who use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the discussion in #15872 , this PR forms the CSS only changes involving moving out of padding styles from
rootclass to separate classgutters