Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Upgrade rollup and related plugins #15939

Merged
merged 1 commit into from May 30, 2019

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented May 29, 2019

Upgraded to the latest version of rollup and its plugins, which produces a smaller bundle

Computed sizes of "build/umd/material-ui.production.min.js" with "umd" format
-  bundler parsing size: 835,914 B
+  bundler parsing size: 819,875 B
-  browser parsing size (minified with terser): 293,979 B
+  browser parsing size (minified with terser): 289,203 B
-  download size (minified and gzipped): 83,766 B
+  download size (minified and gzipped): 82,618 B

@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: 831c6cc...eb0c00d

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 315,057 315,057 86,304 86,304
@material-ui/core/Paper 0.00% 0.00% 67,921 67,921 20,184 20,184
@material-ui/core/Paper.esm 0.00% 0.00% 61,217 61,217 18,981 18,981
@material-ui/core/Popper 0.00% 0.00% 28,740 28,740 10,345 10,345
@material-ui/core/Textarea 0.00% 0.00% 5,513 5,513 2,376 2,376
@material-ui/core/TrapFocus 0.00% 0.00% 3,744 3,744 1,573 1,573
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,978 15,978 5,787 5,787
@material-ui/core/useMediaQuery 0.00% 0.00% 2,106 2,106 975 975
@material-ui/lab 0.00% 0.00% 138,866 138,866 42,660 42,660
@material-ui/styles 0.00% 0.00% 51,386 51,386 15,193 15,193
@material-ui/system 0.00% 0.00% 14,463 14,463 4,181 4,181
Button 0.00% 0.00% 83,901 83,901 25,459 25,459
Modal 0.00% 0.00% 20,343 20,343 6,685 6,685
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 55,977 55,977 14,042 14,042
docs.main 0.00% 0.00% 648,947 648,947 204,664 204,664
packages/material-ui/build/umd/material-ui.production.min.js -1.62% -1.37% 293,979 289,203 83,766 82,618

Generated by 🚫 dangerJS against eb0c00d

@oliviertassinari
Copy link
Member

oliviertassinari commented May 29, 2019

@merceyz Thank you for updating the dependencies! It's important to keep them up to date.

Regarding the bundle size of the UMD bundle, it's not something we want to spend time on to optimize (it's not important). However, I'm happy to see this reduction for free :).

@eps1lon
Copy link
Member

eps1lon commented May 29, 2019

Regarding the bundle size of the UMD bundle, it's not something we want to spend time on to optimize (it's not important). However, I'm happy to see this reduction for free :).

It's interesting though since it might be useful to package every module into a single file i.e. Button.js will be a single file and relative imports will be inlined i.e. dependencies on other components become externals.

@oliviertassinari
Copy link
Member

oliviertassinari commented May 29, 2019

Oh yes, sure, if we do move to a flat JavaScript file publish, that we build with rollup and that people consume in production, it matters.

@oliviertassinari
Copy link
Member

@merceyz Thank you for taking the time!

@merceyz merceyz deleted the core/rollup branch May 30, 2019 11:50
@zannager zannager added the core Infrastructure work going on behind the scenes label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants