Change :valid hack to class not-empty for inputs (also add email type) #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ButuzGOL
force-pushed
the
issue-55-make-class-instead-valid
branch
from
0278528
to
1b61b7a
Compare
|
@hai-cea done |
| @@ -98,12 +98,12 @@ | |||
| box-sizing: border-box; | |||
| padding-bottom: 14px; | |||
|
|
|||
| &[type='text'], &[type='password'] { | |||
| &[type='text'], &[type='password'], &[type='email'] { | |||
There was a problem hiding this comment.
It appears we want to style a wide range of HTML5 inputs. For completeness sake, it would make sense to add type selectors for inputs like tel, number, url, search, etc.
There was a problem hiding this comment.
There is an issue #55
So I think it's better to discuss what exact type are going to be supported
Because for example I tried color picker and it looks no good
|
Would using a classSet be a better option? |
Yes you right its more cleaner |
|
@ButuzGOL Looks like some recent commits caused a conflict. Can you resolve please? |
Conflicts: src/less/components/input.less
|
@hai-cea done |
hai-cea
added a commit
that referenced
this pull request
Dec 24, 2014
Change :valid hack to class not-empty for inputs (also add email type)
|
Thanks @ButuzGOL ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1b61b7a
Also fix for
Uncaught TypeError: Cannot read property 'getDOMNode' of undefined
focus: function() {
if (this.isMounted()) this.refs.input.getDOMNode().focus();
},