Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StepButton] Fix overlap with StepContent #17374

Merged
merged 1 commit into from
Sep 10, 2019
Merged

[StepButton] Fix overlap with StepContent #17374

merged 1 commit into from
Sep 10, 2019

Conversation

rossmmurray
Copy link
Contributor

@rossmmurray rossmmurray commented Sep 9, 2019

Stop StepButton overlapping with StepContent when in a vertical orientation Stepper.

Fix #11857.

Stop StepButton overlapping with StepContent when in a vertical orientation Stepper. Fixes issue 11857.
@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: b968c9a...e9af326

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core +0.01% 🔺 +0.01% 🔺 331,750 331,778 90,593 90,601
@material-ui/core/Paper 0.00% 0.00% 68,813 68,813 20,494 20,494
@material-ui/core/Paper.esm 0.00% 0.00% 62,185 62,185 19,222 19,222
@material-ui/core/Popper 0.00% 0.00% 28,466 28,466 10,177 10,177
@material-ui/core/Textarea 0.00% 0.00% 5,082 5,082 2,133 2,133
@material-ui/core/TrapFocus 0.00% 0.00% 3,834 3,834 1,617 1,617
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 16,410 16,410 5,838 5,838
@material-ui/core/useMediaQuery 0.00% 0.00% 2,558 2,558 1,066 1,066
@material-ui/lab 0.00% 0.00% 153,690 153,690 46,768 46,768
@material-ui/styles 0.00% 0.00% 51,508 51,508 15,308 15,308
@material-ui/system 0.00% 0.00% 15,668 15,668 4,361 4,361
Button 0.00% 0.00% 78,700 78,700 24,045 24,045
Modal 0.00% 0.00% 14,601 14,601 5,121 5,121
Portal 0.00% 0.00% 2,907 2,907 1,322 1,322
Rating 0.00% 0.00% 70,053 70,053 21,881 21,881
Slider 0.00% 0.00% 75,174 75,174 23,206 23,206
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 52,232 52,232 13,768 13,768
docs.main 0.00% 0.00% 597,448 597,448 190,763 190,763
packages/material-ui/build/umd/material-ui.production.min.js +0.01% 🔺 +0.01% 🔺 302,559 302,587 86,941 86,949

Generated by 🚫 dangerJS against e9af326

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: stepper This is the name of the generic UI component, not the React module! labels Sep 9, 2019
@eps1lon eps1lon changed the title [StepButton] Fix StepButton overlap with StepContent [StepButton] Fix overlap with StepContent Sep 10, 2019
@eps1lon eps1lon merged commit 6b118b8 into mui:master Sep 10, 2019
@eps1lon
Copy link
Member

eps1lon commented Sep 10, 2019

@rossmmurray Thank you. This is already a great step forward though the bug is only fixed for the default style. If the padding is overwritten in root then vertical has to be adjusted as well.

@rossmmurray rossmmurray deleted the step-button-overlap-fix branch September 10, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: stepper This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StepButton of non-linear horizontal Stepper protrudes into content
4 participants