Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Batch small changes #17673

Merged
merged 14 commits into from Oct 4, 2019
Merged

[core] Batch small changes #17673

merged 14 commits into from Oct 4, 2019

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Oct 2, 2019 •
edited

If you find a good concern that should be better in a different pull request, let me know, I will break it down.

  • [SpeedDial] Remove dead code (95e616d): the second argument is always undefined.
  • [ExpansionPanels] Better rendering (1211ac0): improve the display of the code sample
  • [docs] Algolia type=search (b0ca69f): replicate reactjs.org type
  • [Portal] Simpler demo (ceff024): remove as many references the Material Design as possible
  • [ClickAwayListerner] Simplify it (180e8b9): remove as many references the Material Design as possible
  • [docs] A major every 6 months would be too frequent (d599677): it seems to be close to the release scheduled used by paid components libs.
  • [theme] Update shadows values (8540d40): used the raw web implementation values, I have noticed that Vuetify uses the same
  • [Typography] Mention key accessibility factors (3185fe2): only mention the most important factors
  • [docs] The gray button background is ugly (a4994f0).
  • [core] Flatten helpers (a25bb56): for consistency.
  • [icons] Add GitHub, remove custom lightbulb icons (66ddf1e): follow the spec: https://material.io/design/color/dark-theme.html#behavior
  • [docs] Improve icon wordings (1f9e753): small tweaks.
  • [TouchRipple] Hide API page (5f78492): the main thing missing to make TouchRipple private is to remove the TouchRippleProp in v5.

Capture d’écran 2019-10-03 à 00 06 57

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Oct 2, 2019
@oliviertassinari oliviertassinari force-pushed the small-changes branch 4 times, most recently from b1642c8 to 9953697 Compare October 2, 2019 20:47
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 2, 2019 •
edited

Details of bundle changes.

Comparing: 9122b60...5f78492

bundle Size Change Size Gzip Change Gzip
LinearProgress ▼ -295 B (-0.45% ) 65.3 kB ▼ -64 B (-0.31% ) 20.3 kB
@material-ui/core[umd] ▼ -14 B (-0.00% ) 306 kB ▲ +28 B (+0.03% ) 88 kB
Link ▼ -343 B (-0.51% ) 66.6 kB ▼ -96 B (-0.46% ) 21 kB
@material-ui/core ▲ +188 B (+0.05% ) 346 kB ▲ +33 B (+0.03% ) 94.9 kB
List ▲ +3 B (0.00% ) 62.4 kB ▼ -4 B (-0.02% ) 19.3 kB
Popper ▼ -122 B (-0.43% ) 28.3 kB ▼ -37 B (-0.36% ) 10.2 kB
ListItem ▲ +118 B (+0.15% ) 77 kB ▲ +6 B (+0.03% ) 24 kB
styles/createMuiTheme -- 16.2 kB ▼ -2 B (-0.03% ) 5.78 kB
ListItemAvatar -- 62.1 kB ▼ -11 B (-0.06% ) 19.3 kB
@material-ui/lab ▲ +184 B (+0.13% ) 144 kB ▲ +68 B (+0.15% ) 44.9 kB
ListItemIcon -- 62.2 kB ▼ -13 B (-0.07% ) 19.4 kB
@material-ui/system -- 15.6 kB ▲ +2 B (+0.05% ) 4.35 kB
ListItemSecondaryAction -- 62 kB ▼ -12 B (-0.06% ) 19.3 kB
Avatar -- 62.6 kB ▼ -9 B (-0.05% ) 19.6 kB
ListItemText ▼ -295 B (-0.45% ) 65 kB ▼ -67 B (-0.33% ) 20.3 kB
Badge ▼ -295 B (-0.45% ) 65.3 kB ▼ -68 B (-0.34% ) 20.2 kB
ListSubheader ▼ -295 B (-0.47% ) 62.8 kB ▼ -73 B (-0.37% ) 19.6 kB
BottomNavigationAction ▼ -48 B (-0.06% ) 75.3 kB ▼ -34 B (-0.14% ) 23.7 kB
Menu ▼ -130 B (-0.15% ) 88.3 kB ▼ -32 B (-0.12% ) 27.6 kB
Breadcrumbs ▼ -295 B (-0.43% ) 68 kB ▼ -70 B (-0.33% ) 21.3 kB
MenuItem ▲ +118 B (+0.15% ) 78 kB ▲ +5 B (+0.02% ) 24.3 kB
ButtonBase ▼ -49 B (-0.07% ) 73.8 kB ▼ -34 B (-0.15% ) 23.1 kB
MenuList ▼ -49 B (-0.07% ) 66 kB ▼ -27 B (-0.13% ) 20.5 kB
Card -- 62.9 kB ▼ -8 B (-0.04% ) 19.6 kB
MobileStepper ▼ -295 B (-0.43% ) 67.7 kB ▼ -61 B (-0.29% ) 21 kB
CardActions -- 62 kB ▼ -7 B (-0.04% ) 19.3 kB
AppBar ▼ -295 B (-0.46% ) 63.9 kB ▼ -62 B (-0.31% ) 19.9 kB
Modal ▼ -130 B (-0.90% ) 14.3 kB ▼ -59 B (-1.17% ) 4.97 kB
CardHeader ▼ -295 B (-0.45% ) 65.1 kB ▼ -62 B (-0.30% ) 20.4 kB
NoSsr -- 2.19 kB ▲ +1 B (+0.10% ) 1.04 kB
Checkbox ▼ -343 B (-0.42% ) 81.6 kB ▼ -99 B (-0.39% ) 25.6 kB
OutlinedInput ▼ -342 B (-0.46% ) 73.5 kB ▼ -93 B (-0.41% ) 22.8 kB
ClickAwayListener ▼ -58 B (-1.48% ) 3.85 kB ▼ -39 B (-2.46% ) 1.55 kB
Popover ▼ -131 B (-0.16% ) 82.7 kB ▼ -39 B (-0.15% ) 25.4 kB
Container ▼ -295 B (-0.47% ) 63.1 kB ▼ -59 B (-0.30% ) 19.6 kB
Portal ▼ -40 B (-1.37% ) 2.87 kB ▼ -32 B (-2.42% ) 1.29 kB
Dialog ▼ -7 B (-0.01% ) 82.5 kB ▼ -21 B (-0.08% ) 25.5 kB
Radio ▼ -7 B (-0.01% ) 82.5 kB ▲ +13 B (+0.05% ) 25.9 kB
DialogContent -- 62.2 kB ▼ -4 B (-0.02% ) 19.4 kB
RadioGroup ▼ -48 B (-0.08% ) 63.2 kB ▼ -28 B (-0.14% ) 19.7 kB
DialogTitle ▼ -295 B (-0.46% ) 64.3 kB ▼ -61 B (-0.30% ) 20.1 kB
Rating ▼ -343 B (-0.49% ) 69.8 kB ▼ -87 B (-0.39% ) 22.2 kB
Drawer ▼ -7 B (-0.01% ) 84.4 kB ▼ -30 B (-0.12% ) 26 kB
RootRef ▼ -272 B (-5.78% ) 4.43 kB ▼ -111 B (-6.24% ) 1.67 kB
ExpansionPanelActions -- 62.1 kB ▼ -11 B (-0.06% ) 19.4 kB
Select ▼ -8 B (-0.01% ) 113 kB ▼ -47 B (-0.14% ) 33.5 kB
ExpansionPanelSummary ▼ -343 B (-0.44% ) 77.9 kB ▼ -95 B (-0.39% ) 24.5 kB
Skeleton -- 62.5 kB ▼ -4 B (-0.02% ) 19.5 kB
Fade ▼ -48 B (-0.21% ) 23.1 kB ▼ -32 B (-0.40% ) 8.03 kB
Slide ▼ -48 B (-0.19% ) 25.1 kB ▼ -24 B (-0.28% ) 8.66 kB
FormControl ▼ -525 B (-0.81% ) 64.3 kB ▼ -137 B (-0.68% ) 19.9 kB
BottomNavigation -- 62.4 kB ▼ -6 B (-0.03% ) 19.5 kB
CardContent -- 62 kB ▼ -6 B (-0.03% ) 19.3 kB
Slider ▼ -343 B (-0.46% ) 75 kB ▼ -81 B (-0.34% ) 23.5 kB
FormGroup -- 62 kB ▼ -6 B (-0.03% ) 19.3 kB
SnackbarContent ▼ -295 B (-0.45% ) 65.8 kB ▼ -61 B (-0.30% ) 20.6 kB
FormLabel ▲ +3 B (0.00% ) 63.2 kB ▼ -5 B (-0.03% ) 19.5 kB
SpeedDial ▼ -172 B (-0.20% ) 85.7 kB ▼ -68 B (-0.25% ) 26.9 kB
GridListTileBar -- 63.2 kB ▼ -4 B (-0.02% ) 19.7 kB
CircularProgress ▼ -295 B (-0.46% ) 64.1 kB ▼ -65 B (-0.32% ) 20.1 kB
FormControlLabel ▼ -295 B (-0.45% ) 65.5 kB ▼ -65 B (-0.32% ) 20.5 kB
SpeedDialAction ▲ +13 B (+0.01% ) 115 kB ▲ +6 B (+0.02% ) 36.4 kB
Hidden ▼ -295 B (-0.44% ) 66.1 kB ▼ -65 B (-0.31% ) 20.6 kB
Fab ▼ -344 B (-0.45% ) 76.6 kB ▼ -98 B (-0.41% ) 23.8 kB
Step -- 62.6 kB ▼ -9 B (-0.05% ) 19.5 kB
IconButton ▼ -344 B (-0.45% ) 76 kB ▼ -98 B (-0.41% ) 23.6 kB
StepButton ▼ -180 B (-0.22% ) 82.1 kB ▼ -67 B (-0.26% ) 25.7 kB
InputLabel -- 65.1 kB ▼ -16 B (-0.08% ) 20.2 kB
@material-ui/styles -- 51.8 kB -- 15.6 kB
colorManipulator -- 3.83 kB -- 1.52 kB
docs.landing -- 54.3 kB -- 14.3 kB
Grid -- 65.1 kB -- 20.3 kB
StepConnector -- 62.7 kB ▼ -6 B (-0.03% ) 19.6 kB
useMediaQuery -- 2.49 kB -- 1.05 kB
StepLabel ▼ -295 B (-0.43% ) 68.6 kB ▼ -68 B (-0.32% ) 21.4 kB
InputBase ▼ -46 B (-0.07% ) 70.2 kB ▼ -30 B (-0.14% ) 22 kB
Stepper -- 64.9 kB ▼ -10 B (-0.05% ) 20.3 kB
CardActionArea ▼ -48 B (-0.06% ) 74.9 kB ▼ -35 B (-0.15% ) 23.6 kB
SvgIcon ▼ -292 B (-0.46% ) 63 kB ▼ -73 B (-0.37% ) 19.6 kB
CardMedia -- 62.4 kB ▼ -7 B (-0.04% ) 19.5 kB
SwipeableDrawer ▼ -7 B (-0.01% ) 90.7 kB ▼ -14 B (-0.05% ) 28 kB
NativeSelect ▼ -339 B (-0.44% ) 76.4 kB ▼ -97 B (-0.40% ) 24 kB
Switch ▼ -343 B (-0.42% ) 80.8 kB ▼ -88 B (-0.35% ) 25.1 kB
CssBaseline -- 57.6 kB ▼ -3 B (-0.02% ) 18 kB
Tab ▼ -343 B (-0.45% ) 76.2 kB ▼ -97 B (-0.40% ) 24.1 kB
DialogContentText ▼ -295 B (-0.46% ) 64 kB ▼ -60 B (-0.30% ) 20 kB
Table -- 62.4 kB ▼ -6 B (-0.03% ) 19.4 kB
ExpansionPanel -- 71.1 kB ▼ -8 B (-0.04% ) 22.1 kB
TableBody -- 62.1 kB ▼ -7 B (-0.04% ) 19.3 kB
TextareaAutosize ▼ -46 B (-0.90% ) 5.06 kB ▼ -28 B (-1.31% ) 2.11 kB
TableCell ▼ -295 B (-0.46% ) 64.1 kB ▼ -64 B (-0.32% ) 20 kB
InputAdornment ▼ -295 B (-0.45% ) 65.1 kB ▼ -71 B (-0.35% ) 20.4 kB
TableFooter -- 62.1 kB ▼ -7 B (-0.04% ) 19.3 kB
ButtonGroup ▼ -295 B (-0.46% ) 64.2 kB ▼ -66 B (-0.33% ) 20 kB
Backdrop ▼ -49 B (-0.07% ) 67.7 kB ▼ -28 B (-0.13% ) 20.9 kB
TableHead -- 62.1 kB ▼ -8 B (-0.04% ) 19.3 kB
Grow ▼ -49 B (-0.21% ) 23.7 kB ▼ -28 B (-0.34% ) 8.15 kB
TableRow -- 62.5 kB ▼ -5 B (-0.03% ) 19.5 kB
Input ▼ -47 B (-0.07% ) 72 kB ▼ -32 B (-0.14% ) 22.4 kB
TableSortLabel ▼ -343 B (-0.44% ) 77.2 kB ▼ -79 B (-0.32% ) 24.4 kB
Button ▼ -343 B (-0.43% ) 79.3 kB ▼ -102 B (-0.41% ) 24.5 kB
Tabs ▼ -343 B (-0.40% ) 85.3 kB ▼ -85 B (-0.31% ) 27.1 kB
StepContent -- 68.9 kB ▼ -5 B (-0.02% ) 21.4 kB
TextField ▲ +151 B (+0.12% ) 121 kB ▼ -3 B (-0.01% ) 35.4 kB
GridList -- 62.5 kB ▼ -11 B (-0.06% ) 19.5 kB
ToggleButton ▼ -343 B (-0.45% ) 76 kB ▼ -88 B (-0.37% ) 23.9 kB
Collapse ▲ +3 B (0.00% ) 67.8 kB -- 20.9 kB
ToggleButtonGroup ▼ -295 B (-0.46% ) 63.2 kB ▼ -71 B (-0.36% ) 19.8 kB
Divider -- 62.6 kB ▼ -7 B (-0.04% ) 19.6 kB
Toolbar -- 62.3 kB ▼ -6 B (-0.03% ) 19.4 kB
FilledInput ▼ -47 B (-0.06% ) 72.9 kB ▼ -29 B (-0.13% ) 22.6 kB
Tooltip ▲ +8 B (+0.01% ) 99 kB ▲ +22 B (+0.07% ) 31.3 kB
Snackbar ▼ -17 B (-0.02% ) 77.1 kB ▼ -2 B (-0.01% ) 24 kB
TreeItem ▼ -343 B (-0.47% ) 73.4 kB ▼ -92 B (-0.40% ) 23 kB
SpeedDialIcon ▼ -295 B (-0.45% ) 64.6 kB ▼ -61 B (-0.30% ) 20.2 kB
TreeView -- 65.9 kB ▼ -1 B (-0.00% ) 20.6 kB
Paper ▲ +3 B (0.00% ) 62.4 kB ▼ -8 B (-0.04% ) 19.3 kB
Typography ▼ -292 B (-0.46% ) 63.6 kB ▼ -78 B (-0.39% ) 19.8 kB
Chip ▼ -343 B (-0.48% ) 70.6 kB ▼ -71 B (-0.33% ) 21.8 kB
ExpansionPanelDetails -- 61.9 kB ▼ -14 B (-0.07% ) 19.3 kB
docs.main ▼ -449 B (-0.07% ) 599 kB ▼ -237 B (-0.12% ) 191 kB
GridListTile ▼ -233 B (-0.36% ) 63.7 kB ▼ -69 B (-0.35% ) 19.9 kB
Box -- 70.7 kB ▼ -1 B (-0.00% ) 21.3 kB
Zoom ▼ -48 B (-0.21% ) 23.1 kB ▼ -31 B (-0.38% ) 8.04 kB
FormHelperText -- 63.3 kB ▼ -15 B (-0.08% ) 19.7 kB
DialogActions -- 62.1 kB ▼ -9 B (-0.05% ) 19.4 kB
StepIcon ▼ -292 B (-0.45% ) 64.7 kB ▼ -81 B (-0.40% ) 20.1 kB
TablePagination ▲ +160 B (+0.12% ) 139 kB ▲ +49 B (+0.12% ) 40.6 kB
Icon ▼ -295 B (-0.47% ) 62.8 kB ▼ -76 B (-0.39% ) 19.6 kB

Generated by 🚫 dangerJS against 5f78492

@oliviertassinari oliviertassinari force-pushed the small-changes branch 2 times, most recently from 66ddf1e to b67af84 Compare October 2, 2019 22:28
@oliviertassinari oliviertassinari added PR: needs review core Infrastructure work going on behind the scenes and removed core Infrastructure work going on behind the scenes PR: needs review labels Oct 3, 2019
@oliviertassinari oliviertassinari merged commit 2bcc874 into mui:master Oct 4, 2019
@mbrookes
Copy link
Member

mbrookes commented Oct 7, 2019

Added "breaking" label with respect to the @material-ui/docs package.

@oliviertassinari oliviertassinari deleted the small-changes branch February 8, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwooding joshwooding joshwooding approved these changes

@mbrookes mbrookes Awaiting requested review from mbrookes

@eps1lon eps1lon Awaiting requested review from eps1lon

Assignees
No one assigned
Labels
breaking change core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oliviertassinari @mui-pr-bot @mbrookes @joshwooding