Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix size comparison sort order #17800

Merged
merged 1 commit into from Oct 9, 2019
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Oct 9, 2019

If you want to order by |X| you can't just |X_a - X_b| but have to |X_a| - |X_b| because math (trivial, proof is left as an exercise for the reader)

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁

@mui-pr-bot
Copy link

No bundle size changes comparing d6f414b...aae0090

Generated by 🚫 dangerJS against aae0090

@eps1lon eps1lon merged commit 31d3008 into mui:master Oct 9, 2019
@eps1lon eps1lon deleted the fix/danger-sort branch October 9, 2019 08:09
@zannager zannager added the docs Improvements or additions to the documentation label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants