[Link] Warn when using plain function component in component
#17825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 83b8323...8df0d58
|
eps1lon
previously requested changes
Oct 10, 2019
eps1lon
added
component: link
eps1lon
changed the title
component
|
@Nikhil-Pavan-Sai Please run |
[Link] Warn when using plain function component in `component`
oliviertassinari
approved these changes
Oct 13, 2019
There was a problem hiding this comment.
I have reverted the new throw error as the discussion in #16454 didn't reach a consensus that it was justified. Sebastian had concerned about it. With hindsight, I'm not sure either it's the best path forward. I suspect it's related to #17119 (comment) but I think that we should better understand what's going on before add this defensive check.
| @@ -32,7 +32,6 @@ describe('<Link />', () => { | |||
| inheritComponent: Typography, | |||
| mount, | |||
| refInstanceof: window.HTMLAnchorElement, | |||
| skip: ['componentProp'], | |||
| @@ -142,7 +143,7 @@ Link.propTypes = { | |||
| * The component used for the root node. | |||
| * Either a string to use a DOM element or a component. | |||
| */ | |||
| component: PropTypes.elementType, | |||
| component: elementTypeAcceptingRef, | |||
There was a problem hiding this comment.
eps1lon
approved these changes
Oct 13, 2019
|
@Nikhil-Pavan-Sai Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16454