[Menu] Add new context menu demo #17839
Conversation
oliviertassinari
added
the
component: menu
oliviertassinari
changed the title
|
No bundle size changes comparing 5d564f9...6654246 |
|
A couple of minor issues from playing with the demo:
|
There was a problem hiding this comment.
I have added a commit that focuses on minimizing the size of the demo. I think that are good. The final step for me would be to migrate the demo to TypeScript.
Also, @mercuriete has proposed to help test the component, do you think that you could have a look at https://deploy-preview-17839--material-ui.netlify.com/components/menus/#context-menu? Thanks.
oliviertassinari
dismissed stale reviews from mbrookes and joshwooding
updated
oliviertassinari
added
PR: needs revision
- removed useEffect - merged state into single object - removed extra className - changed id to 'context-menu' to keep it unique - changed description
Co-Authored-By: Matt <github@nospam.33m.co>
Co-Authored-By: Matt <github@nospam.33m.co>
Co-Authored-By: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
Co-Authored-By: Josh Wooding <12938082+joshwooding@users.noreply.github.com>
oliviertassinari
force-pushed
the
context-menu
branch
from
519570e
to
6654246
Compare
There was a problem hiding this comment.
@SarthakC As per your preference, I have migrated the demo to TypeScript.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6654246:
|
|
@SarthakC First pull request ✌️, thank you, well done |
Cheers! |
Closes #1462