Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Improve demo clarity by using form elements #18241

Merged
merged 2 commits into from
Nov 7, 2019
Merged

[docs] Improve demo clarity by using form elements #18241

merged 2 commits into from
Nov 7, 2019

Conversation

jcuenod
Copy link
Contributor

@jcuenod jcuenod commented Nov 6, 2019 •
edited by oliviertassinari

The Paper element is now rendered with a form and the IconButton uses submit. This makes submitting the InputBase element much clearer and wires in the IconButton.

Fixes #18240

@jcuenod jcuenod mentioned this pull request Nov 6, 2019
Closed
@oliviertassinari oliviertassinari added component: text field This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation labels Nov 6, 2019
@oliviertassinari oliviertassinari changed the title Improve demo clarity by using form elements for Paper and IconButton (Fixes #18240) [docs] Improve demo clarity by using form elements Nov 6, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Nov 6, 2019 •
edited

No bundle size changes comparing b29c294...5ae02a2

Generated by 🚫 dangerJS against 5ae02a2

@jcuenod
Copy link
Contributor Author

jcuenod commented Nov 6, 2019

I see that the failure is because Type '"form"' is not assignable to type ... with a list of html elements. Is there a reason that form is not an option there?

@oliviertassinari
Copy link
Member

I suspect an issue with the TypeScript definitions.

@jcuenod
Copy link
Contributor Author

jcuenod commented Nov 7, 2019

Ja, that's what I mean - shall I add form to that definition?

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 7, 2019 •
edited

@jcuenod I have updated the definition to match the Typography one. It seems to be our best option.

@oliviertassinari oliviertassinari merged commit 7440461 into mui:master Nov 7, 2019
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Oct 28, 2020
Open
@hzhz hzhz mentioned this pull request Mar 8, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Aug 27, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Sep 16, 2021
Open
@hzhz hzhz mentioned this pull request Apr 6, 2024
Open
@zhaleTaheri zhaleTaheri mentioned this pull request Apr 6, 2024
Open
@maniator maniator mentioned this pull request Apr 6, 2024
Open
@akashmitra akashmitra mentioned this pull request Apr 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Expose InputBase onSubmit Event
3 participants
@jcuenod @mui-pr-bot @oliviertassinari