Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ButtonGroup] Fix typings for disabled classes property #18274

Merged
merged 2 commits into from
Nov 8, 2019
Merged

[ButtonGroup] Fix typings for disabled classes property #18274

merged 2 commits into from
Nov 8, 2019

Conversation

ssliman
Copy link
Contributor

@ssliman ssliman commented Nov 8, 2019 •
edited by oliviertassinari

Closes #18272

@ssliman
Copy link
Contributor Author

ssliman commented Nov 8, 2019

This fixes #18272

@mui-pr-bot
Copy link

mui-pr-bot commented Nov 8, 2019 •
edited

No bundle size changes comparing 262c8cf...9603195

Generated by 🚫 dangerJS against 9603195

@oliviertassinari oliviertassinari changed the title [ButtonGroup] fix typings for disabled classes property [ButtonGroup] Fix typings for disabled classes property Nov 8, 2019
@ssliman
Copy link
Contributor Author

ssliman commented Nov 8, 2019

@oliviertassinari thanks for fixing the blank line

@oliviertassinari oliviertassinari merged commit 33eef4f into mui:master Nov 8, 2019
@oliviertassinari
Copy link
Member

@xZliman Thanks

@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Feb 15, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Oct 28, 2020
Open
@hzhz hzhz mentioned this pull request Mar 8, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Aug 27, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Sep 16, 2021
Open
@hzhz hzhz mentioned this pull request Apr 6, 2024
Open
@zhaleTaheri zhaleTaheri mentioned this pull request Apr 6, 2024
Open
@maniator maniator mentioned this pull request Apr 6, 2024
Open
@akashmitra akashmitra mentioned this pull request Apr 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon left review comments

Assignees
No one assigned
Labels
component: ButtonGroup The React component. typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TypeScript] [ButtonGroup] disabled shows as non-valid property in classes
4 participants
@ssliman @mui-pr-bot @oliviertassinari @eps1lon