New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Fix support for renderTags={() => null} #21460
Conversation
fc376de
to
b995bcb
Compare
e316a8e
to
e47fb5f
Compare
@matthenschke If have fixed the rebase. It could be great to add a regression test for the reproduction described in #21333 (comment). |
I have never done a regression test before @oliviertassinari but Ill definitely check it out, do you know what folder the regression test are? |
Details of bundle changes.Comparing: 4a6a12b...907d4b6 Details of page changes
|
did you just fix that example to use new |
@mha15 I think that for now, we should leave it to userland, it's safer. I'm not sure many developers would benefit from an increase of the API surface. |
c7b05f9
to
907d4b6
Compare
@matthenschke Thank you, great first contribution. |
@oliviertassinari Absolutely, thank you for approving my first PR to Material UI :) |
Closes #21333