[docs] Restrict docs markdown and demos to 80ch #21481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 2c56498...c1aee17 Details of page changes
|
eps1lon
commented
Jun 17, 2020
| @@ -31,10 +31,6 @@ const babelConfig = { | |||
|
|
|||
| const workspaceRoot = path.join(__dirname, '../../'); | |||
|
|
|||
| const prettierConfig = prettier.resolveConfig.sync(process.cwd(), { | |||
There was a problem hiding this comment.
This works in a world without overrides. To get options from overrides we need to tell prettier for which file we want the config.
|
@eps1lon Have you consider to use 80 ch? It's the recommended and default max-width from Prettier. Here is how
|
No argument here. Re-used 60ch from the markdown codeblocks. |
oliviertassinari
approved these changes
Jun 17, 2020
eps1lon
changed the title
eps1lon
changed the title
eps1lon
force-pushed
the
docs/fix-overflow-demos
branch
from
035fa96
to
972cbc8
Compare
joshwooding
approved these changes
Jun 17, 2020
eps1lon
force-pushed
the
docs/fix-overflow-demos
branch
from
972cbc8
to
c1aee17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered in #21463 (comment) that some of our demos overflow since they're formatted with a print-width of 100ch. . We reduced it to
6080(#21481 (comment)) in #21463 for inline code blocks but the PR was merged before we had a chance to decide what to do with standalone demos.