Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Fix type tests not being type checked #21539

Merged
merged 2 commits into from
Jun 22, 2020
Merged

[test] Fix type tests not being type checked #21539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6bcc08
actually run type tests
eps1lon Jun 22, 2020
2df4806
fix tests
eps1lon Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/material-ui/test/typescript/components.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,7 +991,11 @@ const SelectTest = () => (
</Select>
);

const InputAdornmentTest = () => <InputAdornment position="end" onClick={() => alert('Hello')} />;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing as of #21383

const InputAdornmentTest = () => (
<InputAdornment position="end" onClick={() => alert('Hello')}>
Some Icon
</InputAdornment>
);

const TooltipComponentTest = () => (
<div>
Expand Down
4 changes: 3 additions & 1 deletion tslint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@
"deprecation": true,
// $ExpectError -> @ts-expect-error
// $ExpectType -> `expectType` from `@material-ui/types`
"expect": false,
// Don't disable this rule unless you made sure `tsc` runs on the same files
// Otherwise some files won't be type-checked
"expect": true,
"file-name-casing": false,
"no-boolean-literal-compare": false,
"no-empty-interface": false,
Expand Down