[core] Batch small changes #21553
Merged
[core] Batch small changes #21553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oliviertassinari
commented
Jun 23, 2020
oliviertassinari
commented
- [docs] Explain why we make each BC a15528e
- [docs] Simpler redirection cleaning logic 9eec519: I don't think that we can know, ahead of time when the 301 are safe to be removed. It seems simpler to add the redirection in sequential order and use git blame to know when they were added.
- [docs] Fix typos be84d9f: Reported by https://www.triplechecker.com/site/material-ui-com
mbrookes
previously requested changes
Jun 23, 2020
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
force-pushed
the
batch-small-changes-v20
branch
from
ffbc514
to
77e7926
Compare
oliviertassinari
removed
the
PR: out-of-date
joshwooding
reviewed
Jun 23, 2020
mbrookes
reviewed
Jun 24, 2020
mbrookes
reviewed
Jun 24, 2020
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Co-authored-by: Matt <github@nospam.33m.co>
oliviertassinari
force-pushed
the
batch-small-changes-v20
branch
from
4320e8c
to
7882405
Compare
eps1lon
approved these changes
Jun 25, 2020
joshwooding
reviewed
Jun 25, 2020
joshwooding
reviewed
Jun 25, 2020
| @@ -21,7 +21,7 @@ This component can be useful in a variety of situations: | |||
|
|
|||
| ## Frame deferring | |||
|
|
|||
| In it's core, the NoSsr component purpose is to **defer rendering**. | |||
| At its core, the NoSsr component's purpose is to **defer rendering**. | |||
There was a problem hiding this comment.
@mbrookes are you happy with the bolded text?
There was a problem hiding this comment.
The wording, or the fact that it's bold? Arguably it isn't "deferred" on the server, but "disabled". However I can find other examples of this usage, so it's probably okay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.