Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Remove in-context translation code & files #21633

Merged
merged 7 commits into from Jul 1, 2020
Merged

[docs] Remove in-context translation code & files #21633

merged 7 commits into from Jul 1, 2020

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Jun 30, 2020 •
edited by oliviertassinari

The "in-context" experimentation doesn't seem to have been efficient at engaging more contributions to the translation. Removing it so we can keep the codebase simpler.

Also auto switch Russian if set in the browser (compare line 6. and 9. in below table)

Capture d’écran 2020-07-01 à 12 00 43

@mbrookes mbrookes added the docs Improvements or additions to the documentation label Jun 30, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Jul 1, 2020 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against cea9482

@oliviertassinari oliviertassinari changed the title [Docs] Remove in-context translation code & files [docs] Remove in-context translation code & files Jul 1, 2020
@oliviertassinari oliviertassinari removed the request for review from dimitropoulos July 1, 2020 10:09
oliviertassinari
oliviertassinari approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reduced a bit the ambition of the change. I think that French and German should be handled in a different pull request, it was messing up with the yarn docs:api command.

@oliviertassinari oliviertassinari merged commit 4024c25 into mui:next Jul 1, 2020
@mbrookes mbrookes deleted the docs-remove-in-context branch November 3, 2020 22:10
@oliviertassinari oliviertassinari added the i18n internationalization label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation i18n internationalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbrookes @mui-pr-bot @oliviertassinari