[docs] Reduce tracking events #21710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Jul 8, 2020
| @@ -193,10 +193,6 @@ function Ad(props) { | |||
| } | |||
|
|
|||
| const delay = setTimeout(() => { | |||
| if (!eventLabel) { | |||
There was a problem hiding this comment.
This was never falsy. Should this bail-out if label is undefined?
eps1lon
commented
Jul 8, 2020
Details of bundle changes.Comparing: 5055114...774e31e Details of page changes
|
oliviertassinari
requested changes
Jul 8, 2020
This was referenced Jul 8, 2020
eps1lon
force-pushed
the
docs/restructure-tracking
branch
from
2fb4008
to
e64058a
Compare
|
@oliviertassinari Rebased onto |
oliviertassinari
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review on per-commit basis is advised.
The previous label was misleading ("expand" for collapsing and showing demo source). It's also less interesting as far as I can tell. At least I use it primarily to see which demos are popular. Collapsing tracking would only make sense if we could track how long the source code is viewed but that's probably too inaccurate to be useful.
Demo source toggle makes up 40% of our events. Maybe we can cut some (in my opinion noisy) events to get below the rate limit (we're currently 40% over it: 14M where 10M is allowed)
We currently dispatch two events if an in-house ad is displayed when we can already derive from the first event if the ad is in-house