[TreeView] Test current behavior of active item removal #21720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
eps1lon
commented
Jul 8, 2020
eps1lon
changed the title
|
I think I'm waiting for #21695 first. We should simplify this logic even more so that we can't even make mistakes in the reducer (I already did). We only need to track which node is active. Whether it is "focused" is derived from the active node and whether the |
oliviertassinari
approved these changes
Jul 14, 2020
github-actions
bot
added
the
PR: out-of-date
|
@eps1lon The linked pull requests and issues have been closed, is the effort still relevant? |
eps1lon
changed the title
eps1lon
added
test
and removed
PR: out-of-date
eps1lon
force-pushed
the
fix/TreeView/tabbable-removal
branch
from
7440f3a
to
6a2b3f1
Compare
eps1lon
commented
Jul 27, 2020
| @@ -32,6 +33,10 @@ describe('<TreeItem />', () => { | |||
| })); | |||
|
|
|||
| describe('warnings', () => { | |||
| beforeEach(() => { | |||
| PropTypes.resetWarningCache(); | |||
There was a problem hiding this comment.
Cleanup of #21695 which added a test that would fail in in watchmode on subsequent runs.
|
Updated test. Please also read the updated PR description. |
oliviertassinari
approved these changes
Jul 27, 2020
joshwooding
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test for #20204 which was closed in #21695 but no test was added as far as I can tell.
The test is especially interesting since the behavior is novel: Removing the focused item moves focus to another item of the widget. In other widgets we let focus return to
document.body.