[core] Don't bail out early if docs:api fails #21726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
force-pushed
the
docs/docs-api-improve
branch
from
d1b2216
to
d2f6c40
Compare
github-actions
bot
added
PR: out-of-date
I have been there too 😆, solving this pain will be appreciated |
oliviertassinari
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of exiting early as soon as a single component crashes
yarn docs:apiwe continue building and list the errors at the end. This ensures that we don't create a big git diff if a single file fails. Ideally I'd get rid of therimrafto reduce the git noise to a minimum but cleaning up is not that trivial so I'm sticking with the crude approach.Basically where
yarn docs:apiwould remove the full directory when a single file changes it now only removes the files that failed. Hopefully that helps working with docs:api.Also did some refactoring to new node APIs.