Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Avatar] Rename variant circle -> circular for consistency #22015

Merged
merged 5 commits into from Aug 3, 2020
Merged

[Avatar] Rename variant circle -> circular for consistency #22015

merged 5 commits into from Aug 3, 2020

Conversation

kodai3
Copy link
Contributor

@kodai3 kodai3 commented Aug 1, 2020 •
edited

Breaking changes

  • Rename circle to circular for consistency. The possible values should be adjectives, not nouns:
-<Avatar variant="circle">
+<Avatar variant="circular">

One item of #21964

@kodai3 kodai3 changed the title [Avatar] rename variant circle -> circular [Avatar] Rename variant circle -> circular Aug 1, 2020
@kodai3 kodai3 changed the title [Avatar] Rename variant circle -> circular [Avatar] Rename variant circle -> circular for consistency Aug 1, 2020
@oliviertassinari oliviertassinari added breaking change component: avatar This is the name of the generic UI component, not the React module! labels Aug 1, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 1, 2020 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against 86a0423

eps1lon
eps1lon previously requested changes Aug 1, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn workspace framer build should fix CI.

@github-actions github-actions bot mentioned this pull request Aug 2, 2020
Closed
@kodai3
Copy link
Contributor Author

kodai3 commented Aug 2, 2020

@eps1lon
Oops, CI fixed

@mnajdova

This comment has been minimized.

Sign in to view
@oliviertassinari

This comment has been minimized.

Sign in to view
@mnemanja

This comment has been minimized.

Sign in to view
@kodai3
Copy link
Contributor Author

kodai3 commented Aug 2, 2020 •
edited

Oh, I have to fix migration.md
It's not round -> circular
It's circle -> circular

@kodai3
Copy link
Contributor Author

kodai3 commented Aug 2, 2020

I updated the migration file and PR description
36f6ad8

@oliviertassinari oliviertassinari merged commit 29cae11 into mui:next Aug 3, 2020
@kodai3 kodai3 mentioned this pull request Aug 3, 2020
Merged
@eps1lon eps1lon added this to the v5 milestone Aug 4, 2020
This was referenced Aug 5, 2020
Closed
Merged
@mbrookes mbrookes mentioned this pull request Sep 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
breaking change component: avatar This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
v5-beta
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kodai3 @mui-pr-bot @mnajdova @oliviertassinari @mnemanja @eps1lon