Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Bump csstype to 3.0.0 #22048

Merged
merged 2 commits into from Aug 3, 2020
Merged

[core] Bump csstype to 3.0.0 #22048

merged 2 commits into from Aug 3, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Aug 2, 2020

These shouldn't actually conflict. If they reveal assignability conflicts then you accidentally used types csstype instead of @material-ui/*.

Some places in the repo wrongly used csstype where React.CSSProperties was more appropriate. csstype is an implementation detail of @types/react.

Closes #22000

@eps1lon eps1lon added typescript package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. package: system Specific to @mui/system labels Aug 2, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 2, 2020

No bundle size changes comparing 0f64a40...376a877

Generated by 🚫 dangerJS against 376a877

@eps1lon eps1lon marked this pull request as ready for review August 2, 2020 18:41
@eps1lon
Copy link
Member Author

eps1lon commented Aug 3, 2020

Could potentially conflict since jss still uses 2.x. Since we're in an experimental phase with alpha release we can be a bit more lenient (especially since it's only typescript).

@eps1lon eps1lon merged commit d7b6051 into mui:next Aug 3, 2020
@eps1lon eps1lon deleted the core/csstype branch August 3, 2020 09:25
kodai3 pushed a commit to kodai3/material-ui that referenced this pull request Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. package: system Specific to @mui/system typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants