Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chip] Custom variant #22161

Merged
merged 1 commit into from Aug 12, 2020
Merged

[Chip] Custom variant #22161

merged 1 commit into from Aug 12, 2020

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Aug 11, 2020

One part of #21749

@@ -151,6 +152,8 @@ export const styles = (theme) => {
marginRight: 3,
},
},
/* Styles applied to the root element if `variant="default"`. */
default: {},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filled is probably a better working for this.. @oliviertassinari @mbrookes what do you think? If you agree I can prepare a PR afterwards for this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@mui-pr-bot
Copy link

Details of bundle changes

Generated by 🚫 dangerJS against c1ba408

@mnajdova mnajdova merged commit 4bf93b6 into mui:next Aug 12, 2020
@zannager zannager added the component: chip This is the name of the generic UI component, not the React module! label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: chip This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants