[test] Fix failing tests on Windows #22369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 3da0347...d7b7eee |
mnajdova
approved these changes
Aug 26, 2020
eps1lon
changed the title
It isn't but that repo is set up to always use lf line endings (https://github.com/merceyz/typescript-to-proptypes/blob/b713f56f5600a3cbcf55cb7c9384780fe09bbd54/.gitattributes#L1) so it shouldn't be a problem, i'll fix it anyways though. Cheers |
Then you could just remove that normalization. I don't think the intention was to only normalize the first linefeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is already fixed upstream but in case it's not @merceyz
Tests failed for me as well with
core.autocrlf=falseon win10 and passed after this fix.@mnajdova Could you check this out and see if it works? If not please include the output of
git config --get core.autocrlf