Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix setRef types #22389

Merged
merged 5 commits into from Aug 31, 2020
Merged

[core] Fix setRef types #22389

merged 5 commits into from Aug 31, 2020

Conversation

Luchanso
Copy link
Contributor

Little fix in types

eps1lon
eps1lon previously requested changes Aug 28, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give a bit more context and preferably add a test that this change fixes?

@mui-pr-bot
Copy link

mui-pr-bot commented Aug 28, 2020 •
edited

No bundle size changes comparing 7c29035...99be6f3

Generated by 🚫 dangerJS against 99be6f3

@Luchanso
Copy link
Contributor Author

Yeah, I just rewrote this function on Typescript, in my project and got errors. Okey, I'll add tests later
image

@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes typescript labels Aug 28, 2020
@oliviertassinari oliviertassinari changed the title fix(types): change ref on mutable ref [core] Fix setRef types Aug 28, 2020
@oliviertassinari
Copy link
Member

I wonder if we should use this report as an opportunity to move the setRef helper to TypeScript.

eps1lon
eps1lon previously requested changes Aug 30, 2020
View reviewed changes
packages/material-ui/src/utils/setRef.ts Outdated Show resolved Hide resolved
@oliviertassinari @eps1lon
Update packages/material-ui/src/utils/setRef.ts
99be6f3 
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
@eps1lon eps1lon added package: material-ui Specific to @mui/material and removed core Infrastructure work going on behind the scenes labels Aug 31, 2020
@eps1lon eps1lon merged commit 37a2733 into mui:next Aug 31, 2020
@eps1lon
Copy link
Member

eps1lon commented Aug 31, 2020

@Luchanso Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
package: material-ui Specific to @mui/material typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Luchanso @mui-pr-bot @oliviertassinari @eps1lon