New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[theme] Add theme.mixins.gutters() in adaptV4Theme #22396
Conversation
props: { | ||
MuiButton: { | ||
disabled: true, | ||
describe('theme.components', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Git is showing this changes very badly 😢 I've just wrapped the tests related to the components section in this describe block. The actual changes starts at https://github.com/mui-org/material-ui/pull/22396/files#diff-201fd01f1ba328161f6d5f589317f47eR197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can hide whitespace from the diff which makes it much more readable: https://github.com/mui-org/material-ui/pull/22396/files/1bd4d245c201010fb90499a3e2e85c8d82a5d52d?diff=unified&w=1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that's brilliant. This needs to be tweeted 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. Why isn't this default view I wonder.. Thanks for sharing it @eps1lon
@material-ui/core: parsed: +0.12% , gzip: +0.14% |
This PR adds the
theme.mixins.gutters()
which was removed with #22109 inside theadaptV4Theme
,