Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[theme] Add theme.mixins.gutters() in adaptV4Theme #22396

Merged
merged 2 commits into from Aug 30, 2020

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Aug 29, 2020

This PR adds the theme.mixins.gutters() which was removed with #22109 inside the adaptV4Theme,

props: {
MuiButton: {
disabled: true,
describe('theme.components', () => {
Copy link
Member Author

@mnajdova mnajdova Aug 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git is showing this changes very badly 😢 I've just wrapped the tests related to the components section in this describe block. The actual changes starts at https://github.com/mui-org/material-ui/pull/22396/files#diff-201fd01f1ba328161f6d5f589317f47eR197

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's brilliant. This needs to be tweeted 😁

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Why isn't this default view I wonder.. Thanks for sharing it @eps1lon

@mui-pr-bot
Copy link

mui-pr-bot commented Aug 29, 2020

@material-ui/core: parsed: +0.12% , gzip: +0.14%

Details of bundle changes

Generated by 🚫 dangerJS against d0564b1

@oliviertassinari oliviertassinari changed the title [Theme] added theme.mixins.gutters() in adaptV4Theme [theme] Add theme.mixins.gutters() in adaptV4Theme Aug 29, 2020
@oliviertassinari oliviertassinari added the new feature New feature or request label Aug 29, 2020
@mnajdova mnajdova merged commit a8acbad into mui:next Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants