Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Migrate more components to react-testing-library #22441

Merged
merged 2 commits into from Sep 2, 2020
Merged

[test] Migrate more components to react-testing-library #22441

merged 2 commits into from Sep 2, 2020

Conversation

baterson
Copy link
Contributor

@baterson baterson commented Sep 1, 2020 •
edited

Replaces enzyme for react-testing-library in the <AccordionDetails /> , <FormGroup />, <Icon />, <Paper />

@oliviertassinari oliviertassinari changed the title Use react-testing-library in AccordionDetails, FormGroup, Icon, Paper [test] Migrate more components to react-testing-library Sep 1, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Sep 1, 2020 •
edited

No bundle size changes comparing 669a0b3...642d448

Generated by 🚫 dangerJS against 642d448

@github-actions github-actions bot mentioned this pull request Sep 1, 2020
Closed
eps1lon
eps1lon approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to more helpful error messages. It's not about the minimal amount of code to get the behavior to pass but providing useful error messages if the behavior is no longer implemented.

@eps1lon eps1lon merged commit d93249f into mui:next Sep 2, 2020
@oliviertassinari oliviertassinari mentioned this pull request Oct 6, 2020
Closed
46 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@baterson @mui-pr-bot @oliviertassinari @eps1lon